Make prefix circuit-breaker test deterministic#144171
Merged
drempapis merged 2 commits intoelastic:mainfrom Mar 16, 2026
Merged
Make prefix circuit-breaker test deterministic#144171drempapis merged 2 commits intoelastic:mainfrom
drempapis merged 2 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
v9.4.0
needs:triage
drempapis
added
>test-failure
elasticsearchmachine
added
the
needs:risk
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
added
>test
spinscale
approved these changes
Mar 13, 2026
Contributor
spinscale
left a comment
spinscale
left a comment
There was a problem hiding this comment.
My assumption here is that the case insensitive automaton is bigger and thus ensures, that the breaker accounts more memory, plus making sure the string has a certain length?
Contributor
Author
That's correct |
drempapis
added
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Mar 16, 2026
(cherry picked from commit c6fafa5) # Conflicts: # muted-tests.yml
This was referenced Mar 16, 2026
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Mar 16, 2026
(cherry picked from commit c6fafa5) # Conflicts: # muted-tests.yml
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Mar 16, 2026
(cherry picked from commit c6fafa5) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 16, 2026
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 16, 2026
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 16, 2026
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Mar 16, 2026
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 16, 2026
…elocations * upstream/main: (33 commits) Unmute InferenceRestIT and DefaultEndPointsIT (elastic#144217) feat: add keep_alive to async task status (elastic#144010) Add explicit isNoOpUpdate() method to MapperService (elastic#144113) Always attach APM Agent (elastic#144120) Fix random_score nightly tests (elastic#144176) Add nested query checks for disabled sequence numbers (elastic#144185) Return sentinel values from Fetch when sequence numbers are disabled (elastic#144212) [Test] Test peer-recovery with sequence numbers pruning (elastic#144116) Remove `scaled-*` field assertions from mixed cluster downsampling test (elastic#144295) Refactor: Use range syntax in ES|QL exponential histogram tests (elastic#144110) Move resolve aliases to IndexAbstractionOptions (elastic#143953) unmute test (elastic#144299) Fix approximation csvtests (elastic#144233) fix test (elastic#144171) Add int4 vector scoring benchmarks (elastic#144105) Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#143023 Mute org.elasticsearch.test.apmintegration.MetricsApmIT testApmIntegration {withOTel=false} elastic#144282 Native cli launcher (elastic#143712) Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#143023 Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResults elastic#144274 ...
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testPrefixCircuitBreakerTripsWithLowLimitwas flaky.It sometimes did not throw
CircuitBreakingExceptionbecause part of the query was random (randomBoolean()), so memory usage could stay below the breaker limit.This change makes the test deterministic by always using case-insensitive prefix clauses with longer prefix values, so the breaker reliably trips.
Solves #143548